linux-kernel - Re: [PATCH] ACPI / PM: Blacklist Low Power S0 Idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Apr 2018 12:06:01 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Yu Chen <yu.c.chen@...el.com>
Cc:     Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Robin Lee <robinlee.sysu@...il.com>,
        Hans de Goede <jwrdegoede@...oraproject.org>
Subject: Re: [PATCH] ACPI / PM: Blacklist Low Power S0 Idle _DSM for ThinkPad X1 Tablet(2016)

On Tuesday, April 10, 2018 5:07:51 PM CEST Yu Chen wrote:
> From: Chen Yu <yu.c.chen@...el.com>
> 
> ThinkPad X1 Tablet(2016) is reported to have issues with
> the Low Power S0 Idle _DSM interface and since this machine
> model generally can do ACPI S3 just fine, and user would
> like to use S3 as default sleep model, add a blacklist
> entry to disable that interface for ThinkPad X1 Tablet(2016).
> 
> Reported-and-tested-by: Robin Lee <robinlee.sysu@...il.com>
> Signed-off-by: Chen Yu <yu.c.chen@...el.com>
> ---
>  drivers/acpi/sleep.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 46cde0912762..465f33aa0bd8 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -364,6 +364,19 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
>  		},
>  	},
> +	/*
> +	 * https://bugzilla.kernel.org/show_bug.cgi?id=199057
> +	 * ThinkPad X1 Tablet(2016) cannot do suspend-to-idle using the Low Power
> +	 * S0 Idle firmware interface.
> +	 */
> +	{
> +	.callback = init_no_lps0,
> +	.ident = "ThinkPad X1 Tablet(2016)",
> +	.matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"),
> +		},
> +	},
>  	{},
>  };
>  
> 

Applied, thanks!