linux-kernel - Re: [PATCH] staging: media: use relevant lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8a26008-f8d5-43d6-b93d-0f3d20074ac0@ideasonboard.com>
Date:   Tue, 24 Apr 2018 11:55:14 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     kernel-janitors@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: use relevant lock

Hi Julia

Thank you for the patch.

On 03/08/17 13:26, Julia Lawall wrote:
> The data protected is video_out2 and the lock that is released is
> &video_out2->dma_queue_lock, so it seems that that lock should be
> taken as well.

I agree - this certainly looks like there was a copy/paste error perhaps and is
locking the wrong video.

> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>




> ---
>  drivers/staging/media/davinci_vpfe/dm365_resizer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> index 857b0e8..4910cb7 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> @@ -1059,7 +1059,7 @@ static void resizer_ss_isr(struct vpfe_resizer_device *resizer)
>  	/* If resizer B is enabled */
>  	if (pipe->output_num > 1 && resizer->resizer_b.output ==
>  	    RESIZER_OUTPUT_MEMORY) {
> -		spin_lock(&video_out->dma_queue_lock);
> +		spin_lock(&video_out2->dma_queue_lock);
>  		vpfe_video_process_buffer_complete(video_out2);
>  		video_out2->state = VPFE_VIDEO_BUFFER_NOT_QUEUED;
>  		vpfe_video_schedule_next_buffer(video_out2);
>