lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9498165854b84321801d8186d3040b1e@AcuMS.aculab.com>
Date:   Tue, 24 Apr 2018 11:24:52 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Greg KH' <gregkh@...uxfoundation.org>,
        "richard.gong@...ux.intel.com" <richard.gong@...ux.intel.com>
CC:     "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "atull@...nel.org" <atull@...nel.org>,
        "mdf@...nel.org" <mdf@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "yves.vandervennet@...ux.intel.com" 
        <yves.vandervennet@...ux.intel.com>,
        "richard.gong@...el.com" <richard.gong@...el.com>
Subject: RE: [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer
 driver

From: Greg KH
> Sent: 23 April 2018 13:03
> On Tue, Mar 27, 2018 at 03:20:10PM -0500, richard.gong@...ux.intel.com wrote:
> > +config INTEL_SERVICE
> 
> Naming is hard, but this is a _very_ generic name, don't you agree?
> 
> > +	tristate "Intel Service Layer"
> 
> As is this.  Can you make this a bit more specific to what hardware is
> being controlled here?
> 
> > +++ b/drivers/misc/intel-service.c
> 
> Same for the file name, why not stratix10.c?
> 
> or intel_svc.c?  That makes it a _bit_ more generic.  Well, not really,
> but it does hide the "genericness" a bit more, right?

It'll all be even worse if (when) Intel decide to sell Altera to
someone else.

	David

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ