linux-kernel - Re: [PATCH] serial: 8250_early: Setup divider when uartclk is passed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Apr 2018 14:27:47 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Matt Redfearn <matt.redfearn@...s.com>,
        Michal Simek <michal.simek@...inx.com>,
        <linux-kernel@...r.kernel.org>, <monstr@...str.eu>
CC:     stable <stable@...r.kernel.org>, Jiri Slaby <jslaby@...e.com>,
        Douglas Anderson <dianders@...omium.org>,
        <linux-serial@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeffy Chen <jeffy.chen@...k-chips.com>
Subject: Re: [PATCH] serial: 8250_early: Setup divider when uartclk is passed

Hi Matt,

On 23.4.2018 15:21, Matt Redfearn wrote:
> Hi Michal
> 
> On 23/04/18 10:18, Michal Simek wrote:
>> device->baud is always non zero value because it is checked already in
>> early_serial8250_setup() before init_port is called.
> 
> True, currently init_port is only called from the one location and so
> the test is a little redundant, though I don't see the harm in testing
> both inputs to the divisor calculation immediately before use such that
> any future call path avoids setting a bad divisor.

I will let others to decide.

> 
>>
>> Fixes: 0ff3ab701963 ("serial: 8250_early: Only set divisor if valid
>> clk & baud")
>> Cc: stable <stable@...r.kernel.org>
> 
> Even if the test is dropped going forward, I wouldn't consider it's
> presence a "bug" such that a fix needs to be backported.

Not a problem with not adding this to stable.

Thanks,
Michal