linux-kernel - Re: [PATCH] vboxvideo: fix mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5372cade-cc6f-3158-aa1b-59d2ffee341f@redhat.com>
Date:   Tue, 24 Apr 2018 15:20:21 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Cihangir Akturk <cakturk@...il.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Michael Thayer <michael.thayer@...cle.com>,
        Peter Rosin <peda@...ntia.se>,
        Keith Packard <keithp@...thp.com>,
        Paolo Cretaro <paolocretaro@...il.com>,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] vboxvideo: fix mode_valid's return type

Hi,

On 24-04-18 15:15, Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
> 
> Fix this by using 'enum drm_mode_status' in the driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>

Thank you for the patch, looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/staging/vboxvideo/vbox_mode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index b265fe924..5c7ea2378 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -573,7 +573,7 @@ static int vbox_get_modes(struct drm_connector *connector)
>   	return num_modes;
>   }
>   
> -static int vbox_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status vbox_mode_valid(struct drm_connector *connector,
>   			   struct drm_display_mode *mode)
>   {
>   	return MODE_OK;
>