linux-kernel - Re: [PATCH v2 1/5] ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5htvs0so92.wl-tiwai@suse.de>
Date:   Tue, 24 Apr 2018 15:55:05 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Oleksandr Andrushchenko" <andr2000@...il.com>
Cc:     <alsa-devel@...a-project.org>, <xen-devel@...ts.xenproject.org>,
        <boris.ostrovsky@...cle.com>, <konrad.wilk@...cle.com>,
        <perex@...ex.cz>, "Juergen Gross" <jgross@...e.com>,
        <linux-kernel@...r.kernel.org>,
        "Oleksandr Andrushchenko" <oleksandr_andrushchenko@...m.com>
Subject: Re: [PATCH v2 1/5] ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver

On Mon, 16 Apr 2018 08:24:49 +0200,
Oleksandr Andrushchenko wrote:
> --- /dev/null
> +++ b/sound/xen/Kconfig
> @@ -0,0 +1,10 @@
> +# ALSA Xen drivers
> +
> +config SND_XEN_FRONTEND
> +	tristate "Xen para-virtualized sound frontend driver"
> +	depends on XEN && SND_PCM

Please do select SND_PCM instead of depends.

> +	select XEN_XENBUS_FRONTEND
> +	default n

"default n" is superfluous, drop it.


thanks,

Takashi