linux-kernel - Re: [PATCH] ftrace/x86: Fix arch_syscall_match_sym_name for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180424150820.GA3396@krava>
Date:   Tue, 24 Apr 2018 17:08:20 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Andy Lutomirski <luto@...nel.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] ftrace/x86: Fix arch_syscall_match_sym_name for x86_64

On Tue, Apr 24, 2018 at 10:33:58AM -0400, Steven Rostedt wrote:
> On Tue, 24 Apr 2018 12:17:38 +0200
> Jiri Olsa <jolsa@...nel.org> wrote:
> 
> > Recent commit changed the name prefix of syscalls
> > for x86_64 (check the 'Fixes:' for commit number).
> > 
> > The names switch from "sys_" prefix to ""__x64_sys_",
> > which made the default matching function always fail.
> > 
> > Consequently the ftrace syscall __init code could not
> > match any syscall metadata so the "syscall" events
> > vanished. This fix returns them back.
> > 
> 
> Hi Jiri,
> 
> I already fixed it and it's queued it my tree. I'm waiting for some
> other patches that are waiting for review so I can start testing and
> push to Linus.
> 
> Also, this was half the fix, the total fix is here:

yep, that's why I enclosed it to CONFIG_X86_64 ;-)

> 
>   http://lkml.kernel.org/r/20180418114509.5a76847d@gandalf.local.home

after long time I needed 'syscalls' events and couldn't believe my eyes ;-)

> 
> I think I'm done waiting, I'll start testing and get my queue out. If
> the other patches don't get the proper acks, I'm not taking them.

cool, I'll stick with my change for now and rebase when it's in

thanks,
jirka