linux-kernel - Re: [PATCH] video: fbdev: aty: radeon_pm: Replace mdelay with msleep in radeonfb_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7290517.RXRYeCv1u3@amdc3058>
Date:   Tue, 24 Apr 2018 17:51:23 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     benh@...nel.crashing.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: aty: radeon_pm: Replace mdelay with
 msleep in radeonfb_pci_suspend

On Tuesday, April 10, 2018 09:47:20 AM Jia-Ju Bai wrote:
> radeonfb_pci_suspend() is never called in atomic context.
> 
> radeonfb_pci_suspend() is only set as ".suspend" in struct pci_driver.
> This function is not called in atomic context.
> 
> Despite never getting called from atomic context, radeonfb_pci_suspend()
> calls mdelay() to busily wait.
> This is not necessary and can be replaced with msleep() 
> and usleep_range() to avoid busy waiting.
> 
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Patch queued for 4.18, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics