linux-kernel - Re: [PATCH] kmemleak: Report if we need to tune KMEMLEAK_EARLY_LOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180424155504.frbxmzq4dw3veudu@armageddon.cambridge.arm.com>
Date:   Tue, 24 Apr 2018 16:55:05 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kmemleak: Report if we need to tune
 KMEMLEAK_EARLY_LOG_SIZE

On Tue, Apr 24, 2018 at 05:51:15PM +0200, Jan Kiszka wrote:
> ...rather than just mysteriously disabling it.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> ---
>  mm/kmemleak.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index 9a085d525bbc..156c0c69cc5c 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -863,6 +863,7 @@ static void __init log_early(int op_type, const void *ptr, size_t size,
>  
>  	if (crt_early_log >= ARRAY_SIZE(early_log)) {
>  		crt_early_log++;
> +		pr_warn("Too many early logs\n");

That's already printed, though later where we have an idea of how big the early
log needs to be:

	if (crt_early_log > ARRAY_SIZE(early_log))
		pr_warn("Early log buffer exceeded (%d), please increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE\n",
			crt_early_log);

-- 
Catalin