linux-kernel - Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m3po2oeg9d.fsf@linaro.org>
Date:   Tue, 24 Apr 2018 17:11:26 +0100
From:   Rui Miguel Silva <rui.silva@...aro.org>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Rui Miguel Silva <rui.silva@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hverkuil@...all.nl>,
        linux-media <linux-media@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Ryan Harkin <ryan.harkin@...aro.org>,
        "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio,
On Tue 24 Apr 2018 at 15:53, Fabio Estevam wrote:
> Hi Rui,
>
> On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva 
> <rui.silva@...aro.org> wrote:
>> Add device tree binding documentation for the OV2680 camera 
>> sensor.
>>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> CC: devicetree@...r.kernel.org
>> Signed-off-by: Rui Miguel Silva <rui.silva@...aro.org>
>> ---
>>  .../devicetree/bindings/media/i2c/ov2680.txt  | 40 
>>  +++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>>  create mode 100644 
>>  Documentation/devicetree/bindings/media/i2c/ov2680.txt
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/media/i2c/ov2680.txt 
>> b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
>> new file mode 100644
>> index 000000000000..0e29f1a113c0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
>> @@ -0,0 +1,40 @@
>> +* Omnivision OV2680 MIPI CSI-2 sensor
>> +
>> +Required Properties:
>> +- compatible: should be "ovti,ov2680".
>> +- clocks: reference to the xvclk input clock.
>> +- clock-names: should be "xvclk".
>
> You missed to pass the camera power supplies as required 
> properties:

Urgh, yes, you are right, I will add this.

---
Cheers,
	Rui

>
> DOVDD-supply
> AVDD-supply
> DVDD-supply