linux-kernel - Re: [PATCH v5 06/23] ASoC: qdsp6: dt-bindings: Add q6asm dt bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cc7f804-4c3c-1955-3d61-0dcbb70ae017@linaro.org>
Date:   Tue, 24 Apr 2018 17:20:07 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     andy.gross@...aro.org, broonie@...nel.org,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        gregkh@...uxfoundation.org, david.brown@...aro.org,
        mark.rutland@....com, lgirdwood@...il.com, plai@...eaurora.org,
        bgoswami@...eaurora.org, tiwai@...e.com, perex@...ex.cz,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, rohkumar@....qualcomm.com,
        spatakok@....qualcomm.com
Subject: Re: [PATCH v5 06/23] ASoC: qdsp6: dt-bindings: Add q6asm dt bindings

Thanks for the review comments,

On 24/04/18 17:17, Rob Herring wrote:
> On Wed, Apr 18, 2018 at 04:31:40PM +0100, srinivas.kandagatla@...aro.org wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>>
>> This patch add DT bindings for ASM (Audio Stream Manager) DSP module.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> Reviewed-and-tested-by: Rohit kumar <rohitkr@...eaurora.org>
>> ---
>>   .../devicetree/bindings/sound/qcom,q6asm.txt       | 33 ++++++++++++++++++++++
>>   include/dt-bindings/sound/qcom,q6asm.h             | 22 +++++++++++++++
>>   2 files changed, 55 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt
>>   create mode 100644 include/dt-bindings/sound/qcom,q6asm.h
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6asm.txt b/Documentation/devicetree/bindings/sound/qcom,q6asm.txt
>> new file mode 100644
>> index 000000000000..d034a50a202a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6asm.txt
>> @@ -0,0 +1,33 @@
>> +Qualcomm Audio Stream Manager (Q6ASM) binding
>> +
>> +Q6ASM is one of the APR audio service on Q6DSP.
>> +Please refer to qcom,apr.txt for details of the coommon apr service bindings
>> +used by the apr service device.
> 
> Need to be clear this is a child of APR.
Yep, I will add a line to state this explicitly.

> 
>> +
>> +- but must contain the following property:
>> +
>> +- compatible:
>> +	Usage: required
>> +	Value type: <stringlist>
>> +	Definition: must be "qcom,asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>".
>> +		    Or "qcom,asm" where the version number can be queried
>> +		    from DSP.
>> +		    example "qcom,asm-v2.0"
>> +
>> += ASM DAIs (Digial Audio Interface)
>> +"dais" subnode of the ASM node represents dai specific configuration
>> +
>> +- #sound-dai-cells
>> +	Usage: required
>> +	Value type: <prop-encoded-array>
>> +	Definition: Must be 1
>> +
>> += EXAMPLE
>> +
>> +q6asm {
> 
> Unit address needed.
Agree, Will fix all such instances.
> 
>> +	compatible = "qcom,q6asm";
> 
> Doesn't match the doc.
Opps!! will fix all such instances with afe and asm too.
>