linux-kernel - Re: [PATCH v4] spi/bcm63xx-hspi: Enable the clock before calling clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180425172816.GI24769@sirena.org.uk>
Date:   Wed, 25 Apr 2018 18:28:16 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Stefan Potyra <Stefan.Potyra@...ktrobit.com>
Cc:     Florian Fainelli <florian.fainelli@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-spi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Jonas Gorski <jonas.gorski@...il.com>,
        ldv-project@...uxtesting.org, sil2review@...ts.osadl.org
Subject: Re: [PATCH v4] spi/bcm63xx-hspi: Enable the clock before calling
 clk_get_rate().

On Wed, Apr 25, 2018 at 06:49:06PM +0200, Stefan Potyra wrote:

> Additionally, prepare/enable the pll_clk before calling clk_get_rate()
> for the same reason.

I don't see this change in the code:

>  		struct clk *pll_clk = devm_clk_get(dev, "pll");
>  
> -		if (IS_ERR(pll_clk))
> -			return PTR_ERR(pll_clk);
> +		if (IS_ERR(pll_clk)) {
> +			ret = PTR_ERR(pll_clk);
> +			goto out_disable_clk;
> +		}
> +
>  
>  		rate = clk_get_rate(pll_clk);
> -		if (!rate)
> -			return -EINVAL;

Did you forget a git add?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)