linux-kernel - Re: [PATCH] do not call trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180425061235.GC595@kroah.com>
Date:   Wed, 25 Apr 2018 08:12:35 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Wei Wang <wvw@...gle.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Wei Wang <wei.vince.wang@...il.com>,
        Ingo Molnar <mingo@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Crt Mori <cmo@...exis.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] do not call trace_printk on non-debug build

On Tue, Apr 24, 2018 at 07:02:34PM +0000, Wei Wang wrote:
> We have seen many cases vendor have shipped kernel/drivers with it, and
> have to clean up that every year. This was brought up in an internal
> discussion and Greg suggested have some feedback from upstream about what
> should be taken to prevent this globally besides fixing individual drivers.
>  From him "I think this change makes sense at a high level, but there could
> be non-obvious reasons why this isn't the way things are handled right now."

I said that?  Heh, I normally say things like "fix all the stupid
drivers", you must have caught me on a good day :)

Anyway, the drivers should be fixed, if they are doing foolish things
like this, the core kernel should not be "protecting them from
themselves", that way lies madness, just talk to the Windows kernel
developers about the hoops they jump through for this type of stuff...

thanks,

greg k-h