linux-kernel - Re: [PATCH] gpio-poweroff: Use gpiod_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180425211125.io6oxvezuxcq6pfk@earth.universe>
Date:   Wed, 25 Apr 2018 23:11:25 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Mike Looijmans <mike.looijmans@...ic.nl>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio-poweroff: Use gpiod_set_value_cansleep

Hi Mike,

On Tue, Apr 24, 2018 at 01:10:30PM +0200, Mike Looijmans wrote:
> The power-off call is done in a context that must be able to sleep, so
> use gpiod_set_value_cansleep instead of the atomic gpiod_set_value call.
> 
> This fixes a kernel warning at shutdown when the gpio is controlled
> through an IO expander for example.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/reset/gpio-poweroff.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/reset/gpio-poweroff.c b/drivers/power/reset/gpio-poweroff.c
> index 6273ad3..38206c3 100644
> --- a/drivers/power/reset/gpio-poweroff.c
> +++ b/drivers/power/reset/gpio-poweroff.c
> @@ -35,11 +35,11 @@ static void gpio_poweroff_do_poweroff(void)
>  	gpiod_direction_output(reset_gpio, 1);
>  	mdelay(100);
>  	/* drive inactive, also active->inactive edge */
> -	gpiod_set_value(reset_gpio, 0);
> +	gpiod_set_value_cansleep(reset_gpio, 0);
>  	mdelay(100);
>  
>  	/* drive it active, also inactive->active edge */
> -	gpiod_set_value(reset_gpio, 1);
> +	gpiod_set_value_cansleep(reset_gpio, 1);
>  
>  	/* give it some time */
>  	mdelay(timeout);
> -- 
> 1.9.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)