linux-kernel - Re: [PATCH] arm64: dts: qcom: Add SDM845 SMEM nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180425220626.GM2052@tuxbook-pro>
Date:   Wed, 25 Apr 2018 15:06:26 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Sibi Sankar <sibis@...eaurora.org>
Cc:     andy.gross@...aro.org, david.brown@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, catalin.marinas@....com, will.deacon@....com,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-soc@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Add SDM845 SMEM nodes

On Wed 25 Apr 07:46 PDT 2018, Sibi Sankar wrote:
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 9be763da0664..bea985045759 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -21,6 +21,27 @@
>  		reg = <0 0x80000000 0 0>;
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		memory@...c0000 {
> +			reg = <0 0x85fc0000 0 0x40000>;

The region 0x85fe0000 + 0x20000 seems to be command db, which should be
described on its own. So please reduce the size to 0x20000.

> +			no-map;
> +		};
> +
> +		smem_mem: smem-mem@...00000 {

smem_mem: memory@...00000 ?

> +			reg = <0x0 0x86000000 0x0 0x200000>;
> +			no-map;
> +		};
> +
> +		memory@...00000 {

memory@...00000

> +			reg = <0 0x86200000 0 0x2d00000>;
> +			no-map;
> +		};
> +	};
> +

The rest looks good.

Regards,
Bjorn