linux-kernel - Re: [GIT PULL] dma mapping fixes for 4.17-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180425065930.GA16791@infradead.org>
Date:   Tue, 24 Apr 2018 23:59:30 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     David Rientjes <rientjes@...gle.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] dma mapping fixes for 4.17-rc3

On Tue, Apr 24, 2018 at 11:54:26PM -0700, David Rientjes wrote:
> Shouldn't that test for dev->coherent_dma_mask < DMA_BIT_MASK(32) be more 
> accurately <=? 

No, it should really be <.  The exactly 32-bit case is already covered
with GFP_DMA32.  Eventualy it should be < 24-bit with a separate
GFP_DMA32 case for > 32-bit && < 64-bit.  Takashi has been working on
that, but it is 4.18 material.