linux-kernel - Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180425105645.GP4615@localhost>
Date:   Wed, 25 Apr 2018 12:56:45 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Johan Hovold <johan@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andreas Kemnade <andreas@...nade.info>,
        Arnd Bergmann <arnd@...db.de>,
        "H . Nikolaus Schaller" <hns@...delico.com>,
        Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote:
> > +#define GNSS_MINORS	16
> 
> Why only 16?  Just have to start somewhere?

Yeah, a mostly arbitrarily picked number. I figured only developers
would have an interest in having even that many GNSS receivers in one
system. But it can be raised, now or later.

> > +static int gnss_open(struct inode *inode, struct file *file)
> > +{
> > +	struct gnss_device *gdev;
> > +	int ret = 0;
> > +
> > +	gdev = container_of(inode->i_cdev, struct gnss_device, cdev);
> > +
> > +	get_device(&gdev->dev);
> > +
> > +	nonseekable_open(inode, file);
> > +	file->private_data = gdev;
> > +
> > +	down_write(&gdev->rwsem);
> 
> Just curious, why a rwsem?  They can be slower than a normal semaphore,
> is this really a contentious lock?

I use the rwsem to deal with hotplugging; the underlying device can go
away at any time and the core makes sure that no further calls into the
corresponding driver is made once all currently executing callbacks
return.

> > +	if (gdev->disconnected) {
> > +		ret = -ENODEV;
> > +		goto unlock;
> > +	}
> > +
> > +	if (gdev->count++ == 0) {
> > +		ret = gdev->ops->open(gdev);
> > +		if (ret)
> > +			gdev->count--;
> 
> Why do we care about the opens here?  Do you only want the "child
> driver" to have open called once, like a tty driver?  Does it matter?

Exactly, core deals with the open counts so that the individual gnss
drivers need not. Serdev, for example, blows up if you try to open the
same device twice.

> Again, just curious.
> 
> > +	}
> > +unlock:
> > +	up_write(&gdev->rwsem);
> > +
> > +	if (ret)
> > +		goto err_put_device;
> > +
> > +	return 0;
> > +
> > +err_put_device:
> > +	put_device(&gdev->dev);
> > +
> > +	return ret;
> 
> Those last 9 lines can be rewritten as just:
> 
> 	if (!ret)
> 		put_device(&gdev->dev);
> 
> 	return ret;

Yeah, I usually prefer having an explicit return 0 in the success path
and clearly separate the error paths even if it adds few extra lines.
This case could become an exception though.

> > +static ssize_t gnss_write(struct file *file, const char __user *buf,
> > +		size_t count, loff_t *pos)
> > +{
> > +	struct gnss_device *gdev = file->private_data;
> > +	size_t written = 0;
> > +	int ret;
> > +
> > +	dev_dbg(&gdev->dev, "%s - count = %zu\n", __func__, count);
> 
> Nit, some of these initial dev_dbg() calls might be able to be removed,
> as ftrace should handle the tracing code now, right?

Right. The were probably mostly useful to me during development, and can
be added back later if it turns out they have any further value.

> > +static const struct file_operations gnss_fops = {
> > +	.owner		= THIS_MODULE,
> > +	.open		= gnss_open,
> > +	.release	= gnss_release,
> > +	.read		= gnss_read,
> > +	.write		= gnss_write,
> > +	.poll		= gnss_poll,
> > +	.llseek		= no_llseek,
> > +};

> > +struct gnss_device *gnss_allocate_device(struct device *parent)
> > +{
> > +	struct gnss_device *gdev;
> > +	struct device *dev;
> > +	int id;
> > +	int ret;
> > +
> > +	gdev = kzalloc(sizeof(*gdev), GFP_KERNEL);
> > +	if (!gdev)
> > +		return NULL;
> > +
> > +	id = ida_simple_get(&gnss_minors, 0, GNSS_MINORS, GFP_KERNEL);
> > +	if (id < 0) {
> > +		kfree(gdev);
> > +		return ERR_PTR(id);
> > +	}
> > +
> > +	gdev->id = id;
> > +
> > +	dev = &gdev->dev;
> > +	device_initialize(dev);
> > +	dev->devt = gnss_first + id;
> > +	dev->class = gnss_class;
> > +	dev->parent = parent;
> > +	dev->release = gnss_device_release;
> > +	dev_set_drvdata(dev, gdev);
> > +	dev_set_name(dev, "gnss%d", id);
> > +
> > +	init_rwsem(&gdev->rwsem);
> > +	mutex_init(&gdev->read_mutex);
> > +	mutex_init(&gdev->write_mutex);
> > +	init_waitqueue_head(&gdev->read_queue);
> > +
> > +	ret = kfifo_alloc(&gdev->read_fifo, GNSS_READ_FIFO_SIZE, GFP_KERNEL);
> > +	if (ret)
> > +		goto err_put_device;
> > +
> > +	gdev->write_buf = kzalloc(GNSS_WRITE_BUF_SIZE, GFP_KERNEL);
> > +	if (!gdev->write_buf)
> > +		goto err_put_device;
> > +
> > +	cdev_init(&gdev->cdev, &gnss_fops);
> > +	gdev->cdev.owner = THIS_MODULE;
> 
> This protects this module from being unloaded, but how do you pass on
> the module reference counts to the "child" gnss driver?  Am I just
> missing that logic here somewhere?

Due to the hotplug support mentioned above, I do not need to pin the
"child" gnss driver modules. Their devices can go away at any time, be
it due to hotplugging, driver unbind through sysfs, or module unload.

> Anyway, minor things, this looks really clean, nice job.

Thanks again!

Johan