linux-kernel - Re: [PATCH] net: wireless: ti: wlcore: sdio: allow pm to handle sdio power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180425135552.GX5671@atomide.com>
Date:   Wed, 25 Apr 2018 06:55:52 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Eyal Reizer <eyalreizer@...il.com>
Cc:     kvalo@...eaurora.org, linux-wireless@...r.kernel.org,
        robh@...nel.org, sre@...nel.org, linux-kernel@...r.kernel.org,
        Eyal Reizer <eyalr@...com>
Subject: Re: [PATCH] net: wireless: ti: wlcore: sdio: allow pm to handle sdio
 power

* Eyal Reizer <eyalreizer@...il.com> [180425 13:43]:
> pm_runtime handles sdio power on and power off transitions.
> An old workaround for trying to control the power explicitly from the
> driver was in fact causing failures on suspend/resume as the mmc layer
> already power the module on resume.
> 
> In case of resume pm_runtime_get sync returns a positive device's usage
> count causing the driver to try an re-initialize an already initialized
> device. This was causing sdio bus failure on resume.
> 
> Remove this manual power on/off sequence as it is in-fact not needed.
> 
> Signed-off-by: Eyal Reizer <eyalr@...com>
> Cc: stable@...r.kernel.org

Stable cc dropped, see Documentation/process/stable-kernel-rules.rst.

Looks good to me:

Acked-by: Tony Lindgren <tony@...mide.com>