linux-kernel - Re: [PATCH] apple-gmux: fix gmux_get_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcrmckbbkvGZ+B74DQXOkZddQog-D++iEeVVNCrDKUWww@mail.gmail.com>
Date:   Wed, 25 Apr 2018 17:17:21 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] apple-gmux: fix gmux_get_client_id()'s return type

On Tue, Apr 24, 2018 at 4:15 PM, Luc Van Oostenryck
<luc.vanoostenryck@...il.com> wrote:
> The method struct vga_switcheroo_handler::get_client_id() is defined
> as returning an 'enum vga_switcheroo_client_id' but the implementation
> in this driver, gmux_get_client_id(), returns an 'int'.
>
> Fix this by returning 'enum vga_switcheroo_client_id' in this driver too.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> ---
>  drivers/platform/x86/apple-gmux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
> index 7c4eb86c8..fd2ffebc8 100644
> --- a/drivers/platform/x86/apple-gmux.c
> +++ b/drivers/platform/x86/apple-gmux.c
> @@ -495,7 +495,7 @@ static int gmux_set_power_state(enum vga_switcheroo_client_id id,
>         return gmux_set_discrete_state(apple_gmux_data, state);
>  }
>
> -static int gmux_get_client_id(struct pci_dev *pdev)
> +static enum vga_switcheroo_client_id gmux_get_client_id(struct pci_dev *pdev)
>  {
>         /*
>          * Early Macbook Pros with switchable graphics use nvidia
> --
> 2.17.0
>



-- 
With Best Regards,
Andy Shevchenko