linux-kernel - Re: [PATCH v2 4/4] ARM: amba: Fix wrong indentation in driver_override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD0t5oNj5Rgj6tiuwVFegyJiOzV8jsV=OwHHa9USrQLjzLPCgQ@mail.gmail.com>
Date:   Wed, 25 Apr 2018 08:58:18 -0700
From:   Todd Kjos <tkjos@...roid.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Russell King <linux@...linux.org.uk>,
        Adrian Salido <salidoa@...gle.com>,
        Nicolai Stange <nstange@...e.de>,
        Sasha Levin <Alexander.Levin@...rosoft.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] ARM: amba: Fix wrong indentation in driver_override_store()

Reviewed-by: Todd Kjos <tkjos@...roid.com>

On Tue, Apr 10, 2018 at 6:21 AM, Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
> Indentation is one TAB and 7 spaces instead of 2 TABs.
>
> Fixes: 3cf385713460eb2b ("ARM: 8256/1: driver coamba: add device binding path 'driver_override'")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/amba/bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index 4a3ac31c07d0ee49..842314a439fdd4eb 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -101,8 +101,8 @@ static ssize_t driver_override_store(struct device *_dev,
>         if (strlen(driver_override)) {
>                 dev->driver_override = driver_override;
>         } else {
> -              kfree(driver_override);
> -              dev->driver_override = NULL;
> +               kfree(driver_override);
> +               dev->driver_override = NULL;
>         }
>         device_unlock(_dev);
>
> --
> 2.7.4
>