linux-kernel - Re: [PATCH] staging: ks7010: fix ks_wlan_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180426200009.lpfmn47d6hz75w6b@ltop.local>
Date:   Thu, 26 Apr 2018 22:00:10 +0200
From:   Luc Van Oostenryck <luc.vanoostenryck@...il.com>
To:     Janusz Lisiecki <janusz.lisiecki@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Sergio Paracuellos <sergio.paracuellos@...il.com>
Subject: Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type

On Wed, Apr 25, 2018 at 06:44:38PM +0200, Janusz Lisiecki wrote:
> Maybe inside ks_wlan_start_xmit, instead of "return 0;", there should be
> "return NETDEV_TX_OK;" and "return NETDEV_TX_BUSY;" otherwise. It is just
> suggestion.

I see, yes. However, since:
1) this sort of change is really outside the goal of this patch;
2) more change are needed for returning NETDEV_TX_BUSY (most not
   free the skb, probably should stop the queue/device, ...);
3) the driver is actively improving by someone just now (Sergio);
I prefer to let this change to Sergio.

I'll resend my (unimportant) change in a few weeks (if still needed).

Cheers,
-- Luc