linux-kernel - Re: [PATCH] mm: don't show nr_indirectly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1804261453460.238822@chino.kir.corp.google.com>
Date:   Thu, 26 Apr 2018 14:55:05 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Michal Hocko <mhocko@...nel.org>
cc:     Roman Gushchin <guro@...com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        kernel-team@...com, Vlastimil Babka <vbabka@...e.cz>,
        Matthew Wilcox <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Johannes Weiner <hannes@...xchg.org>
Subject: Re: [PATCH] mm: don't show nr_indirectly_reclaimable in
 /proc/vmstat

On Thu, 26 Apr 2018, Michal Hocko wrote:

> > Don't show nr_indirectly_reclaimable in /proc/vmstat,
> > because there is no need in exporting this vm counter
> > to the userspace, and some changes are expected
> > in reclaimable object accounting, which can alter
> > this counter.
> > 
> > Signed-off-by: Roman Gushchin <guro@...com>
> > Cc: Vlastimil Babka <vbabka@...e.cz>
> > Cc: Matthew Wilcox <willy@...radead.org>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Alexander Viro <viro@...iv.linux.org.uk>
> > Cc: Michal Hocko <mhocko@...e.com>
> > Cc: Johannes Weiner <hannes@...xchg.org>
> 
> This is quite a hack. I would much rather revert the counter and fixed
> it the way Vlastimil has proposed. But if there is a strong opposition
> to the revert then this is probably the simples thing to do. Therefore
> 

Implementing this counter as a vmstat doesn't make much sense based on how 
it's used.  Do you have a link to what Vlastimil proposed?  I haven't seen 
mention of alternative ideas.