linux-kernel - RE: [PATCH 1/5] X86: Hyper-V: Enlighten APIC access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1804270052400.1596@nanos.tec.linutronix.de>
Date:   Fri, 27 Apr 2018 00:55:00 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>
cc:     KY Srinivasan <kys@...rosoft.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "apw@...onical.com" <apw@...onical.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>
Subject: RE: [PATCH 1/5] X86: Hyper-V: Enlighten APIC access

Michael,

On Thu, 26 Apr 2018, Michael Kelley (EOSG) wrote:

> > -----Original Message-----
> > From: kys@...uxonhyperv.com <kys@...uxonhyperv.com>
> > Sent: Wednesday, April 25, 2018 11:13 AM
> > To: x86@...nel.org; gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> > devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com; jasowang@...hat.com;
> > tglx@...utronix.de; hpa@...or.com; Stephen Hemminger <sthemmin@...rosoft.com>;
> > Michael Kelley (EOSG) <Michael.H.Kelley@...rosoft.com>; vkuznets@...hat.com
> > Cc: KY Srinivasan <kys@...rosoft.com>
> > Subject: [PATCH 1/5] X86: Hyper-V: Enlighten APIC access

Please fix your MUA not to pointlessly copy the whole mail header.

> > +void __init hv_apic_init(void)
> > +{
> > +	if (ms_hyperv.hints & HV_X64_APIC_ACCESS_RECOMMENDED) {
> > +		pr_info("Hyper-V: Using MSR ased APIC access\n");
> 
> Typo here.  "ased" should be "based".

And please trim the reply to the relevant point. It's annoying to find that
single line of review comment in the useless pile of quoted patch.

Thanks,

	tglx