linux-kernel - Re: [PATCH] gpio: make several const arrays static, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYq-xLFXi8vLkbSsnaAboJjS5rDVWPHeNRdo=FrmsagaQ@mail.gmail.com>
Date:   Fri, 27 Apr 2018 01:03:12 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     William Breathitt Gray <vilhelm.gray@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: make several const arrays static, shrinks object size

On Wed, Apr 18, 2018 at 7:26 PM, Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> Don't populate the const read-only arrays 'port' on the stack but
> instead make them static. Makes the object code smaller:
>
> Before:
>   text    data     bss     dec    hex filename
>   8542    4088     672   13302   33f6 drivers/gpio/gpio-gpio-mm.o
>  10959    4952     832   16743   4167 drivers/gpio/gpio-104-dio-48e.o
>   9022    5064    1408   15494   3c86 drivers/gpio/gpio-104-idi-48.o
>
> After:
>   text    data     bss     dec    hex filename
>   8372    4144     672   13188   3384 drivers/gpio/gpio-gpio-mm.o
>  10790    5008     832   16630   40f6 drivers/gpio/gpio-104-dio-48e.o
>   8853    5152    1408   15413   3c35 linux/drivers/gpio/gpio-104-idi-48.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

I had already applied some part of the patch.

Dropped patches to one file for this reason.

Please check the result.

Patch applied!

Yours,
Linus Walleij