linux-kernel - Re: [PATCH] drm/bridge: tc358767: fix mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14260440.xDKvmdEgPi@avalon>
Date:   Fri, 27 Apr 2018 02:22:14 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/bridge: tc358767: fix mode_valid's return type

Hi Luc,

Thank you for the patch.

On Tuesday, 24 April 2018 16:14:52 EEST Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
> 
> Fix this by using 'enum drm_mode_status' in the driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/gpu/drm/bridge/tc358767.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358767.c
> b/drivers/gpu/drm/bridge/tc358767.c index 08ab7d6ae..0fd9cf275 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1102,7 +1102,7 @@ static bool tc_bridge_mode_fixup(struct drm_bridge
> *bridge, return true;
>  }
> 
> -static int tc_connector_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status tc_connector_mode_valid(struct drm_connector
> *connector, struct drm_display_mode *mode)
>  {
>  	/* DPI interface clock limitation: upto 154 MHz */

-- 
Regards,

Laurent Pinchart