linux-kernel - Re: [PATCH] arm64: skip cpu nodes marked as disabled in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Apr 2018 08:25:14 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Rohit Khanna <rokhanna@...dia.com>
Cc:     "will.deacon@....com" <will.deacon@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thierry Reding <treding@...dia.com>,
        Alexander Van Brunt <avanbrunt@...dia.com>,
        Bo Yan <byan@...dia.com>,
        Jason Sequeira <jsequeira@...dia.com>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>
Subject: Re: [PATCH] arm64: skip cpu nodes marked as disabled in DT

On Wed, Apr 25, 2018 at 11:36:06PM +0000, Rohit Khanna wrote:
> Adding few other folks.

It looks fine to me but cc'ing Mark and Lorenzo (and it should have been
posted on linux-arm-kernel@...ts.infradead.org).

> From: Rohit Khanna
> Sent: Wednesday, April 25, 2018 4:08 PM
> To: catalin.marinas@....com; will.deacon@....com
> Cc: linux-kernel@...r.kernel.org; Rohit Khanna
> Subject: [PATCH] arm64: skip cpu nodes marked as disabled in DT
> 
> Skip the CPU nodes that are marked as disabled in DT.
> 
> Bug 1828570
> 
> Signed-off-by: Rohit Khanna <rokhanna@...dia.com>
> Reviewed-on: http://git-master/r/1245333
> Reviewed-by: Alexander Van Brunt <avanbrunt@...dia.com>
> ---
>  arch/arm64/kernel/smp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index f3e2e3aec0b0..2b4371b0948d 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -578,6 +578,10 @@ static void __init of_parse_and_init_cpus(void)
>         for_each_node_by_type(dn, "cpu") {
>                 u64 hwid = of_get_cpu_mpidr(dn);
> 
> +               /* Check to see if the cpu is disabled */
> +               if (!of_device_is_available(dn))
> +                       goto next;
> +
>                 if (hwid == INVALID_HWID)
>                         goto next;
> 
> --
> 2.1.4