linux-kernel - Re: [PATCH v4 09/12] mmc: sdhci-omap: Workaround for Errata i834

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Apr 2018 10:53:20 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH v4 09/12] mmc: sdhci-omap: Workaround for Errata i834

On 25/04/18 15:09, Kishon Vijay Abraham I wrote:
> Errata i834 in AM572x Sitara Processors Silicon Revision 2.0, 1.1
> (SPRZ429L July 2014–Revised April 2018 [1]) mentions the maximum
> obtainable timeout through MMC host controller is 700ms. And for
> commands taking longer than 700ms, hardware timeout should be
> disabled and software timeout should be used.
> 
> The workaround for Errata i834 can be achieved by adding
> SDHCI_QUIRK2_DISABLE_HW_TIMEOUT quirk in sdhci-omap.
> 
> [1] -> http://www.ti.com/lit/er/sprz429l/sprz429l.pdf
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> Acked-by: Tony Lindgren <tony@...mide.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-omap.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 2d9ea23610d5..b2c54940d032 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -715,7 +715,8 @@ static const struct sdhci_pltfm_data sdhci_omap_pdata = {
>  		  SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC,
>  	.quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN |
>  		   SDHCI_QUIRK2_PRESET_VALUE_BROKEN |
> -		   SDHCI_QUIRK2_RSP_136_HAS_CRC,
> +		   SDHCI_QUIRK2_RSP_136_HAS_CRC |
> +		   SDHCI_QUIRK2_DISABLE_HW_TIMEOUT,
>  	.ops = &sdhci_omap_ops,
>  };
>  
>