linux-kernel - Re: [PATCH][v5] tools/power turbostat: if --iterations, print for specific count of iterations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180426000847.GA20079@sandybridge-desktop>
Date:   Thu, 26 Apr 2018 08:08:48 +0800
From:   Yu Chen <yu.c.chen@...el.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Len Brown <lenb@...nel.org>,
        Artem Bityutskiy <artem.bityutskiy@...el.com>,
        Doug Smythies <dsmythies@...us.net>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][v5] tools/power turbostat: if --iterations, print for
 specific count of iterations

On Mon, Apr 23, 2018 at 10:48:39AM +0200, Rafael J. Wysocki wrote:
> On Saturday, April 14, 2018 6:10:55 AM CEST Yu Chen wrote:
> > From: Chen Yu <yu.c.chen@...el.com>
> > 
> > There's a use case during test to only print specific round of iterations
> > if --iterations is specified, for example, with this patch applied:
> > 
> > turbostat -i 5 -r 4
> > will capture 4 samples with 5 seconds interval.
> > 
> > Cc: Len Brown <lenb@...nel.org>
> > Cc: Rafael J Wysocki <rjw@...ysocki.net>
> > Cc: Artem Bityutskiy <artem.bityutskiy@...el.com>
> > Cc: Doug Smythies <dsmythies@...us.net>
> > Cc: linux-pm@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Signed-off-by: Chen Yu <yu.c.chen@...el.com>
[cut]...
> > +		if (iterations && (++done_iters >= iterations))
> 
> The inner parens are not needed here (and similarly below).
> 
> If you fix this little one, please feel free to add
> 
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> to the patch (FWIW). 
> 
OK, will do, thanks!
Yu