linux-kernel - Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ2zRJfcSWbi_zwvtMnu_eGqAi684Wh3qWfjMazJqNsUA@mail.gmail.com>
Date:   Thu, 26 Apr 2018 11:06:05 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     William Breathitt Gray <vilhelm.gray@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks
 object size

On Thu, Apr 5, 2018 at 2:00 PM, Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> Don't populate the const read-only array 'ports' on the stack but instead
> make it static. Makes the object code smaller by over 100 buytes:
>
> Before:
>    text    data     bss     dec     hex filename
>   10959    4952     832   16743    4167 drivers/gpio/gpio-104-dio-48e.o
>
> After:
>    text    data     bss     dec     hex filename
>   10790    5008     832   16630    40f6 drivers/gpio/gpio-104-dio-48e.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied with William's ACK.

Yours,
Linus Walleij