linux-kernel - Re: [PATCH v2 3/7] powerpc: use task_pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c793bf59-5670-e01c-fe63-903844650991@au1.ibm.com>
Date:   Thu, 26 Apr 2018 19:25:22 +1000
From:   Andrew Donnellan <andrew.donnellan@....ibm.com>
To:     Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
Cc:     "Alastair D'Silva" <alastair@....ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, mikey@...ling.org,
        vaibhav@...ux.vnet.ibm.com, aneesh.kumar@...ux.vnet.ibm.com,
        malat@...ian.org, felix@...ux.vnet.ibm.com, pombredanne@...b.com,
        sukadev@...ux.vnet.ibm.com, npiggin@...il.com,
        gregkh@...uxfoundation.org, arnd@...db.de,
        fbarrat@...ux.vnet.ibm.com, corbet@....net,
        "Alastair D'Silva" <alastair@...ilva.org>,
        Christophe Lombard <clombard@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2 3/7] powerpc: use task_pid_nr() for TID allocation

On 25/04/18 07:12, Sukadev Bhattiprolu wrote:
> Yes. Like with PIDR, was trying to assign TIDR initially to all threads.
> But since only a subset of threads need/use TIDR, we can assign the
> value later (when set_thread_tidr() is called). So we should be able to
> use task_pid_nr() then.

OK. Alastair has also confirmed with me that truncating the pid to a u16 
should be safe, so therefore:

Reviewed-by: Andrew Donnellan <andrew.donnellan@....ibm.com>


-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@....ibm.com  IBM Australia Limited