| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAK-LDbKxTS-13yC4CQH+fQxTM6_Dw85ftyj7sLHf3yooJwPXOA@mail.gmail.com>
Date: Thu, 26 Apr 2018 18:27:18 +0530
From: Vaishali Thakkar <vthakkar1994@...il.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Daniel Vetter <daniel@...ll.ch>, alexander.deucher@....com,
linux-renesas-soc@...r.kernel.org, alexandre.belloni@...tlin.com,
Heiko Stuebner <heiko@...ech.de>, airlied@...ux.ie,
Linus Walleij <linus.walleij@...aro.org>, stefan@...er.ch,
hjc@...k-chips.com, kraxel@...hat.com,
Benjamin Gaignard <benjamin.gaignard@...aro.org>,
nouveau@...ts.freedesktop.org,
Marek Vašut <marex@...x.de>,
David1.Zhou@....com, linux-samsung-soc@...r.kernel.org,
jy0922.shim@...sung.com, linux-rockchip@...ts.infradead.org,
Tomi Valkeinen <tomi.valkeinen@...com>, linux@...linux.org.uk,
krzk@...nel.org, jonathanh@...dia.com, z.liuxinliang@...ilicon.com,
maxime.ripard@...tlin.com, kong.kongxinwei@...ilicon.com,
Kukjin Kim <kgene@...nel.org>, bskeggs@...hat.com,
linux-arm-msm@...r.kernel.org, CK HU <ck.hu@...iatek.com>,
airlied@...hat.com, virtualization@...ts.linux-foundation.org,
linux-tegra@...r.kernel.org, puck.chen@...ilicon.com,
intel-gfx@...ts.freedesktop.org, etnaviv@...ts.freedesktop.org,
brodkin@...opsys.com, dri-devel@...ts.freedesktop.org,
rodrigo.vivi@...el.com, Matthias Brugger <matthias.bgg@...il.com>,
wen <s@...e.org>, vincent.abriou@...com,
linux-arm-kernel@...ts.infradead.org, inki.dae@...sung.com,
amd-gfx@...ts.freedesktop.org, alison.wang@...escale.com,
freedreno@...ts.freedesktop.org, sw0312.kim@...sung.com,
nicolas.ferre@...rochip.com,
Philippe Cornu <philippe.cornu@...com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
yannick.fertre@...com, Kyungmin Park <kyungmin.park@...sung.com>,
Noralf Trønnes <noralf@...nnes.org>,
p.zabel@...gutronix.de, Zou Rongrong <zourongrong@...il.com>,
linux-mediatek@...ts.infradead.org, shawnguo@...nel.org,
christian.koenig@....com, l.stach@...gutronix.de
Subject: Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses
On Thu, Apr 26, 2018 at 6:15 PM, Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
> Hi Daniel,
>
> On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote:
>> On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote:
>> > It's been a while since we introduced drm_dev{get/put} functions
>> > to replace reference/unreference in drm subsystem for the
>> > consistency purpose. So, with this patch, let's just replace
>> > all current use cases of drm_dev_unref() with drm_dev_put and remove
>> > the function itself.
>> >
>> > Coccinelle was used for mass-patching.
>> >
>> > Signed-off-by: Vaishali Thakkar <vthakkar1994@...il.com>
>>
>> Thanks for doing this. Unfortunately drm moves pretty fast, so already a
>> conflict when I tried to apply this. Some drivers are also in their own
>> trees, so this might lead to more fun :-/
>>
>> Can you pls split it up per-driver (just the directories under
>> drivers/gpu/drm/ is enough)? Final patch to remove the function might then
>> get stalled a bit ofc.
>
> I requested a single patch instead of splitting it per driver, you might want
> to blame me for that.
>
>> Also can you pls update ./scripts/coccinelle/api/drm-get-put.cocci and
>> remove that spatch hunk in the final patch, since we no longer need it?
>
> How about just rerunning the coccinelle patch when it's time to apply this ?
> There's precedent for performing such automated changes, and it would ensure
> that no driver is left out.
I was planning to send patches to remove all remaining reference/unreference
functions by the weekend [as there aren't much remaining now and I see that
new drivers keeps adding them instead of new API]. So, wanted to delete whole
cocci file after that. I thought of dividing a patch per function because
Laurent requested to send a single patch for all files.
But if we are going to split it per driver under gpu/drm, would it work if per
driver patch contains all function cases? Also, would you be fine with taking a
patch for removal of coccinelle file via your tree? Then I can include that in
the same patchset as well.
Thanks!
>> > ---
>> >
>> > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
>> > drivers/gpu/drm/arc/arcpgu_drv.c | 4 ++--
>> > drivers/gpu/drm/armada/armada_drv.c | 6 +++---
>> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++--
>> > drivers/gpu/drm/drm_drv.c | 13 -------------
>> > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--
>> > drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 ++--
>> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 ++--
>> > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++--
>> > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 8 ++++----
>> > drivers/gpu/drm/i915/selftests/huge_pages.c | 2 +-
>> > drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c | 2 +-
>> > drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 +-
>> > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
>> > drivers/gpu/drm/i915/selftests/i915_gem_object.c | 2 +-
>> > drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
>> > drivers/gpu/drm/i915/selftests/i915_vma.c | 2 +-
>> > drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 2 +-
>> > drivers/gpu/drm/imx/imx-drm-core.c | 4 ++--
>> > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +++---
>> > drivers/gpu/drm/msm/msm_drv.c | 8 ++++----
>> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++--
>> > drivers/gpu/drm/nouveau/nouveau_platform.c | 2 +-
>> > drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++--
>> > drivers/gpu/drm/pl111/pl111_drv.c | 4 ++--
>> > drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
>> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
>> > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 ++--
>> > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
>> > drivers/gpu/drm/sti/sti_drv.c | 8 ++++----
>> > drivers/gpu/drm/stm/drv.c | 4 ++--
>> > drivers/gpu/drm/sun4i/sun4i_drv.c | 4 ++--
>> > drivers/gpu/drm/tegra/drm.c | 4 ++--
>> > drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 6 +++---
>> > drivers/gpu/drm/tve200/tve200_drv.c | 4 ++--
>> > drivers/gpu/drm/udl/udl_drv.c | 2 +-
>> > drivers/gpu/drm/vc4/vc4_drv.c | 4 ++--
>> > drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
>> > drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 2 +-
>> > drivers/gpu/drm/zte/zx_drm_drv.c | 4 ++--
>> > include/drm/drm_drv.h | 1 -
>> > 41 files changed, 73 insertions(+), 87 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>
--
Vaishali
http://vaishalithakkar.in/
Powered by blists - more mailing lists