linux-kernel - Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180426131404.GP4813@piout.net>
Date:   Thu, 26 Apr 2018 15:14:53 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Daniel Vetter <daniel@...ll.ch>,
        Vaishali Thakkar <vthakkar1994@...il.com>,
        alexander.deucher@....com, linux-renesas-soc@...r.kernel.org,
        heiko@...ech.de, airlied@...ux.ie, linus.walleij@...aro.org,
        stefan@...er.ch, hjc@...k-chips.com, kraxel@...hat.com,
        benjamin.gaignard@...aro.org, nouveau@...ts.freedesktop.org,
        marex@...x.de, David1.Zhou@....com,
        linux-samsung-soc@...r.kernel.org, jy0922.shim@...sung.com,
        linux-rockchip@...ts.infradead.org, tomi.valkeinen@...com,
        linux@...linux.org.uk, krzk@...nel.org, jonathanh@...dia.com,
        z.liuxinliang@...ilicon.com, maxime.ripard@...tlin.com,
        kong.kongxinwei@...ilicon.com, kgene@...nel.org,
        bskeggs@...hat.com, linux-arm-msm@...r.kernel.org,
        ck.hu@...iatek.com, airlied@...hat.com,
        virtualization@...ts.linux-foundation.org,
        linux-tegra@...r.kernel.org, puck.chen@...ilicon.com,
        intel-gfx@...ts.freedesktop.org, etnaviv@...ts.freedesktop.org,
        brodkin@...opsys.com, dri-devel@...ts.freedesktop.org,
        rodrigo.vivi@...el.com, matthias.bgg@...il.com, wens@...e.org,
        vincent.abriou@...com, linux-arm-kernel@...ts.infradead.org,
        inki.dae@...sung.com, amd-gfx@...ts.freedesktop.org,
        alison.wang@...escale.com, freedreno@...ts.freedesktop.org,
        sw0312.kim@...sung.com, nicolas.ferre@...rochip.com,
        philippe.cornu@...com, linux-kernel@...r.kernel.org,
        yannick.fertre@...com, kyungmin.park@...sung.com,
        noralf@...nnes.org, p.zabel@...gutronix.de, zourongrong@...il.com,
        linux-mediatek@...ts.infradead.org, shawnguo@...nel.org,
        christian.koenig@....com, l.stach@...gutronix.de
Subject: Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's
 uses

Hi,

On 26/04/2018 15:45:44+0300, Laurent Pinchart wrote:
> Hi Daniel,
> 
> On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote:
> > On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote:
> > > It's been a while since we introduced drm_dev{get/put} functions
> > > to replace reference/unreference in drm subsystem for the
> > > consistency purpose. So, with this patch, let's just replace
> > > all current use cases of drm_dev_unref() with drm_dev_put and remove
> > > the function itself.
> > > 
> > > Coccinelle was used for mass-patching.
> > > 
> > > Signed-off-by: Vaishali Thakkar <vthakkar1994@...il.com>
> > 
> > Thanks for doing this. Unfortunately drm moves pretty fast, so already a
> > conflict when I tried to apply this. Some drivers are also in their own
> > trees, so this might lead to more fun :-/
> > 
> > Can you pls split it up per-driver (just the directories under
> > drivers/gpu/drm/ is enough)? Final patch to remove the function might then
> > get stalled a bit ofc.
> 
> I requested a single patch instead of splitting it per driver, you might want 
> to blame me for that.
> 

Doesn't splitting the change per driver break bisectability unless there
is a guarantee that the change in include/drm/drm_drv.h is applied after
all the driver trees have been merged?


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com