linux-kernel - [PATCH 1/2] dmaengine: axi-dmac: Use devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Apr 2018 09:12:38 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     linux-kernel@...r.kernel.org
Cc:     dmaengine@...r.kernel.org, vinod.koul@...el.com,
        dan.j.williams@...el.com, lars@...afoo.de,
        Moritz Fischer <mdf@...nel.org>
Subject: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

Use devm_request_irq() instead of request_irq() to request the IRQ.

Signed-off-by: Moritz Fischer <mdf@...nel.org>
---

Hi Lars,

was there a specific reason not to use devm_request_irq() ?

Cheers,

Moritz

---
 drivers/dma/dma-axi-dmac.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 2419fe524daa..75ccedaa96d2 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -687,8 +687,9 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unregister_device;
 
-	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
-		dev_name(&pdev->dev), dmac);
+	ret = devm_request_irq(&pdev->dev, dmac->irq,
+			       axi_dmac_interrupt_handler, 0,
+			       dev_name(&pdev->dev), dmac);
 	if (ret)
 		goto err_unregister_of;
 
@@ -711,7 +712,6 @@ static int axi_dmac_remove(struct platform_device *pdev)
 	struct axi_dmac *dmac = platform_get_drvdata(pdev);
 
 	of_dma_controller_free(pdev->dev.of_node);
-	free_irq(dmac->irq, dmac);
 	tasklet_kill(&dmac->chan.vchan.task);
 	dma_async_device_unregister(&dmac->dma_dev);
 	clk_disable_unprepare(dmac->clk);
-- 
2.17.0