linux-kernel - Re: [PATCH] USB: serial: option: adding support for ublox R410M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Apr 2018 23:22:25 +0700
From:   Lars Melin <larsm17@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Bjørn Mork <bjorn@...k.no>,
        SZ Lin (林上智) <sz.lin@...a.com>,
        stable <stable@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dan Williams <dcbw@...hat.com>
Subject: Re: [PATCH] USB: serial: option: adding support for ublox R410M

On 4/26/2018 23:12, Johan Hovold wrote:
> On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote:
>> On 4/26/2018 18:39, Lars Melin wrote:
>>> On 4/26/2018 18:19, Bjørn Mork wrote:
>>>> Anyway, Qualcomm based designs are definitely handled by both drivers.
>>>> Using qcserial only makes sense if the interface layout matches one of
>>>> the defined shared schemes, which currently are:
>>>>
>>>>      QCSERIAL_G2K = 0,    /* Gobi 2000 */
>>>>      QCSERIAL_G1K = 1,    /* Gobi 1000 */
>>>>      QCSERIAL_SWI = 2,    /* Sierra Wireless */
>>>>      QCSERIAL_HWI = 3,    /* Huawei */
>>>
>>> It seems to me that this Quectel device matches the interface layout for
>>> Gobi1K:
>>>
>>>            * Gobi 1K USB layout:
>>>            * 0: DM/DIAG (use libqcdm from ModemManager for communication)
>>>            * 1: serial port (doesn't respond)
>>>            * 2: AT-capable modem port
>>>            * 3: QMI/net
>>>            */
> 
>> Ublox, not Quectel..
> 
> Yeah, but qcserial appears to select a different altsetting for the DM
> port for Gobi 1000, an altsetting which this particular device does not
> have.
> 
> I didn't re-read the full thread I referred to earlier, but I think in
> it, Dan mentioned Gobi 1000 device requiring firmware to be loaded too.
> 
> So if it's not a G1K device, we probably shouldn't be using qcserial
> even if the interface layout happens to match.
> 
> Thanks,
> Johan

Good point, I forgot about the required firmware loading for Gobi1K.
So this device should be handled by the option driver.

/Lars