linux-kernel - Re: [PATCH 2/6 v3] iommu: of: make of_pci_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180427171537.lvzygghnuolk6cnh@rob-hp-laptop>
Date:   Fri, 27 Apr 2018 12:15:37 -0500
From:   Rob Herring <robh@...nel.org>
To:     Nipun Gupta <nipun.gupta@....com>
Cc:     robin.murphy@....com, will.deacon@....com, mark.rutland@....com,
        catalin.marinas@....com, hch@....de, gregkh@...uxfoundation.org,
        joro@...tes.org, m.szyprowski@...sung.com, shawnguo@...nel.org,
        frowand.list@...il.com, bhelgaas@...gle.com,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org, linux-pci@...r.kernel.org,
        bharat.bhushan@....com, stuyoder@...il.com,
        laurentiu.tudor@....com, leoyang.li@....com
Subject: Re: [PATCH 2/6 v3] iommu: of: make of_pci_map_rid() available for
 other devices too

On Fri, Apr 27, 2018 at 03:57:02PM +0530, Nipun Gupta wrote:
> iommu-map property is also used by devices with fsl-mc. This
> patch moves the of_pci_map_rid to generic location, so that it
> can be used by other busses too.
> 
> 'of_pci_map_rid' is renamed here to 'of_map_rid' and there is no
> functional change done in the API.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@....com>
> ---
>  drivers/iommu/of_iommu.c   |   6 +--
>  drivers/of/address.c       | 102 +++++++++++++++++++++++++++++++++++++++++++++
>  drivers/of/irq.c           |   7 ++--
>  drivers/pci/of.c           | 101 --------------------------------------------
>  include/linux/of_address.h |  11 +++++
>  include/linux/of_pci.h     |  10 -----
>  6 files changed, 120 insertions(+), 117 deletions(-)

of/address.c isn't really the best fit either, though I don't have a 
better suggestion. 

I'm guessing this breaks on Sparc which doesn't build of/address.c. 
I guess move it to base.c and of.h if that is the case.

Rob