linux-kernel - Re: [PATCH 0/6] PCI: leak fixes, removable generic PCI host, assorted stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180427221602.GB73256@bhelgaas-glaptop.roam.corp.google.com>
Date:   Fri, 27 Apr 2018 17:16:02 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Jingoo Han <jingoohan1@...il.com>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Will Deacon <will.deacon@....com>
Subject: Re: [PATCH 0/6] PCI: leak fixes, removable generic PCI host,
 assorted stuff

On Tue, Apr 24, 2018 at 05:13:36PM +0200, Jan Kiszka wrote:
> This primarily enables to unbind the generic PCI host controller without
> leaving lots of memory leaks behind. A previous proposal patch 5 was
> rejected because of those issues [1].
> 
> The fixes have been validated in the Jailhouse setup, where we add and
> remove a virtual PCI host controller on hypervisor activation/
> deactivation, with the help of kmemleak.
> 
> Besides that, there is tiny PCI API cleanup at the beginning and
> support for manually enabled PCI domains at the end that enables the
> Jailhouse scenario.

Sounds like you have a couple things lined up for a v2 posting.  When you
do that, would you mind updating the function references in subjects,
changelogs, and comments to include "()" after the function name, e.g.,
s/pci_get_new_domain_nr/pci_get_new_domain_nr()/?

> [1] http://lkml.iu.edu/hypermail/linux/kernel/1606.3/00072.html
> 
> 
> CC: Jingoo Han <jingoohan1@...il.com>
> CC: Joao Pinto <Joao.Pinto@...opsys.com>
> CC: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> CC: Will Deacon <will.deacon@....com>
> 
> Jan Kiszka (6):
>   PCI: Make pci_get_new_domain_nr static
>   PCI: Fix memory leak of devm_pci_alloc_host_bridge
>   PCI: Introduce devm_of_pci_get_host_bridge_resources
>   PCI: Convert of_pci_get_host_bridge_resources users to devm variant
>   PCI: Add support for unbinding the generic PCI host controller
>   arm: Allow to enable PCI_DOMAINS manually
> 
>  arch/arm/Kconfig                       |  7 ++-
>  drivers/pci/dwc/pcie-designware-host.c |  2 +-
>  drivers/pci/host/pci-aardvark.c        |  5 +-
>  drivers/pci/host/pci-ftpci100.c        |  4 +-
>  drivers/pci/host/pci-host-common.c     | 13 +++++
>  drivers/pci/host/pci-host-generic.c    |  1 +
>  drivers/pci/host/pci-v3-semi.c         |  3 +-
>  drivers/pci/host/pci-versatile.c       |  3 +-
>  drivers/pci/host/pci-xgene.c           |  3 +-
>  drivers/pci/host/pcie-altera.c         |  5 +-
>  drivers/pci/host/pcie-iproc-platform.c |  4 +-
>  drivers/pci/host/pcie-rcar.c           |  5 +-
>  drivers/pci/host/pcie-rockchip.c       |  4 +-
>  drivers/pci/host/pcie-xilinx-nwl.c     |  4 +-
>  drivers/pci/host/pcie-xilinx.c         |  4 +-
>  drivers/pci/of.c                       | 93 ++++++++++++++++++++++------------
>  drivers/pci/pci.c                      |  6 +--
>  drivers/pci/probe.c                    |  4 +-
>  include/linux/of_pci.h                 | 14 ++++-
>  include/linux/pci-ecam.h               |  1 +
>  include/linux/pci.h                    |  3 --
>  21 files changed, 120 insertions(+), 68 deletions(-)
> 
> -- 
> 2.13.6
>