linux-kernel - Re: [PATCH 1/5] X86: Hyper-V: Enlighten APIC access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Apr 2018 13:44:23 +0800
From:   kbuild test robot <lkp@...el.com>
To:     kys@...uxonhyperv.com
Cc:     kbuild-all@...org, x86@...nel.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
        olaf@...fle.de, apw@...onical.com, jasowang@...hat.com,
        tglx@...utronix.de, hpa@...or.com, sthemmin@...rosoft.com,
        Michael.H.Kelley@...rosoft.com, vkuznets@...hat.com
Subject: Re: [PATCH 1/5] X86: Hyper-V: Enlighten APIC access

Hi Srinivasan,

I love your patch! Yet something to improve:

[auto build test ERROR on v4.17-rc2]
[also build test ERROR on next-20180426]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/kys-linuxonhyperv-com/X86-Hyper-V-APIC-enlightenments/20180427-114416
config: i386-randconfig-b0-04270034 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   arch/x86/hyperv/hv_apic.c: In function 'hv_apic_read':
>> arch/x86/hyperv/hv_apic.c:65:3: error: implicit declaration of function 'native_apic_mem_read' [-Werror=implicit-function-declaration]
      return native_apic_mem_read(reg);
      ^
   arch/x86/hyperv/hv_apic.c: In function 'hv_apic_write':
>> arch/x86/hyperv/hv_apic.c:79:3: error: implicit declaration of function 'native_apic_mem_write' [-Werror=implicit-function-declaration]
      native_apic_mem_write(reg, val);
      ^
   arch/x86/hyperv/hv_apic.c: In function 'hv_apic_init':
>> arch/x86/hyperv/hv_apic.c:92:3: error: implicit declaration of function 'apic_set_eoi_write' [-Werror=implicit-function-declaration]
      apic_set_eoi_write(hv_apic_eoi_write);
      ^
>> arch/x86/hyperv/hv_apic.c:93:3: error: 'apic' undeclared (first use in this function)
      apic->read      = hv_apic_read;
      ^
   arch/x86/hyperv/hv_apic.c:93:3: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +/native_apic_mem_read +65 arch/x86/hyperv/hv_apic.c

    51	
    52	static u32 hv_apic_read(u32 reg)
    53	{
    54		u32 reg_val, hi;
    55	
    56		switch (reg) {
    57		case APIC_EOI:
    58			rdmsr(HV_X64_MSR_EOI, reg_val, hi);
    59			return reg_val;
    60		case APIC_TASKPRI:
    61			rdmsr(HV_X64_MSR_TPR, reg_val, hi);
    62			return reg_val;
    63	
    64		default:
  > 65			return native_apic_mem_read(reg);
    66		}
    67	}
    68	
    69	static void hv_apic_write(u32 reg, u32 val)
    70	{
    71		switch (reg) {
    72		case APIC_EOI:
    73			wrmsr(HV_X64_MSR_EOI, val, 0);
    74			break;
    75		case APIC_TASKPRI:
    76			wrmsr(HV_X64_MSR_TPR, val, 0);
    77			break;
    78		default:
  > 79			native_apic_mem_write(reg, val);
    80		}
    81	}
    82	
    83	static void hv_apic_eoi_write(u32 reg, u32 val)
    84	{
    85		wrmsr(HV_X64_MSR_EOI, val, 0);
    86	}
    87	
    88	void __init hv_apic_init(void)
    89	{
    90		if (ms_hyperv.hints & HV_X64_APIC_ACCESS_RECOMMENDED) {
    91			pr_info("Hyper-V: Using MSR ased APIC access\n");
  > 92			apic_set_eoi_write(hv_apic_eoi_write);
  > 93			apic->read      = hv_apic_read;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25200 bytes)