linux-kernel - RE: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW2PR2101MB1113169BD526E9EA58ED400FA08D0@MW2PR2101MB1113.namprd21.prod.outlook.com>
Date:   Fri, 27 Apr 2018 06:31:24 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "apw@...onical.com" <apw@...onical.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "hpa@...or.com" <hpa@...or.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>
Subject: RE: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments



> -----Original Message-----
> From: Michael Kelley (EOSG)
> Sent: Thursday, April 26, 2018 3:55 PM
> To: KY Srinivasan <kys@...rosoft.com>; x86@...nel.org;
> gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> jasowang@...hat.com; tglx@...utronix.de; hpa@...or.com; Stephen
> Hemminger <sthemmin@...rosoft.com>; vkuznets@...hat.com
> Subject: RE: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments
> 
> > -----Original Message-----
> > From: kys@...uxonhyperv.com <kys@...uxonhyperv.com>
> > Sent: Wednesday, April 25, 2018 11:13 AM
> > To: x86@...nel.org; gregkh@...uxfoundation.org; linux-
> kernel@...r.kernel.org;
> > devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> jasowang@...hat.com;
> > tglx@...utronix.de; hpa@...or.com; Stephen Hemminger
> <sthemmin@...rosoft.com>;
> > Michael Kelley (EOSG) <Michael.H.Kelley@...rosoft.com>;
> vkuznets@...hat.com
> > Cc: KY Srinivasan <kys@...rosoft.com>
> > Subject: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments
> >
> > From: "K. Y. Srinivasan" <kys@...rosoft.com>
> >
> > Hyper-V supports hypercalls to implement IPI; use them.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > ---
> >  arch/x86/hyperv/hv_apic.c          | 125
> +++++++++++++++++++++++++++++++++++++
> >  arch/x86/hyperv/hv_init.c          |  17 +++++
> >  arch/x86/include/asm/hyperv-tlfs.h |   9 +++
> >  arch/x86/include/asm/mshyperv.h    |   1 +
> >  4 files changed, 152 insertions(+)
> >
> > diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
> > index e0a5b36208fc..7f3322ecfb01 100644
> > --- a/arch/x86/hyperv/hv_apic.c
> > +++ b/arch/x86/hyperv/hv_apic.c
> > @@ -30,6 +30,14 @@
> >  #include <linux/slab.h>
> >  #include <linux/cpuhotplug.h>
> >
> > +struct ipi_arg_non_ex {
> > +	u32 vector;
> > +	u32 reserved;
> > +	u64 cpu_mask;
> > +};
> 
> I think we'd like to put structures like this, which are defined in the
> Hyper-V Top Level Functional Spec, in hyperv-tlfs.h.  Also, the 5.0b
> version of the TLFS, which is latest, shows this structure on page 100:
> 
> 	u32 vector;
> 	u8  targetvtl;
> 	u8  reserved[3];
> 	u64 cpu_mask;
> 

Good point. I will make the necessary adjustments.

Regards,

K. Y