lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4c0bae0e-6338-b6ae-4296-d16c40a7c770@gmail.com> Date: Thu, 26 Apr 2018 17:22:09 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-kernel@...r.kernel.org Cc: linux-renesas-soc@...r.kernel.org, kernel-janitors@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...oirfairelinux.com>, netdev@...r.kernel.org Subject: Re: [PATCH 31/61] net: dsa: simplify getting .drvdata On 04/19/2018 07:06 AM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com> > --- > > Build tested only. buildbot is happy. Please apply individually. Similar to my other comment on patch 4, would not you want to use dev_set_drvdata() to be consistent? This would be functionally equivalent. -- Florian
Powered by blists - more mailing lists