linux-kernel - Re: [PATCH v7 08/11] ARM: sun9i: smp: Add is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180427102614.1558a1ae@dell-desktop.home>
Date:   Fri, 27 Apr 2018 10:26:14 +0200
From:   Mylène Josserand <mylene.josserand@...tlin.com>
To:     Maxime Ripard <maxime.ripard@...tlin.com>
Cc:     linux@...linux.org.uk, wens@...e.org, marc.zyngier@....com,
        mark.rutland@....com, robh+dt@...nel.org, horms@...ge.net.au,
        geert@...ux-m68k.org, magnus.damm@...il.com,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
        clabbe.montjoie@...il.com, quentin.schulz@...tlin.com,
        thomas.petazzoni@...tlin.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 08/11] ARM: sun9i: smp: Add is_a83t field

Hello,

On Mon, 23 Apr 2018 10:14:23 +0200
Maxime Ripard <maxime.ripard@...tlin.com> wrote:

> On Fri, Apr 20, 2018 at 11:10:19PM +0200, Mylène Josserand wrote:
> > To prepare the support of sun8i-a83t, add a field in the smp_data
> > structure to know if we are on sun9i-a80 or sun8i-a83t.
> > 
> > Add also a global variable to retrieve which architecture we are
> > having.
> > 
> > Signed-off-by: Mylène Josserand <mylene.josserand@...tlin.com>
> > ---
> >  arch/arm/mach-sunxi/mc_smp.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm/mach-sunxi/mc_smp.c b/arch/arm/mach-sunxi/mc_smp.c
> > index 03f021d0c73e..48e5f4db64b6 100644
> > --- a/arch/arm/mach-sunxi/mc_smp.c
> > +++ b/arch/arm/mach-sunxi/mc_smp.c
> > @@ -74,6 +74,7 @@ static void __iomem *sram_b_smp_base;
> >  
> >  extern void sunxi_mc_smp_secondary_startup(void);
> >  extern void sunxi_mc_smp_resume(void);
> > +static int is_a83t;
> >  
> >  static bool sunxi_core_is_cortex_a15(unsigned int core, unsigned int cluster)
> >  {
> > @@ -624,6 +625,7 @@ struct sunxi_mc_smp_nodes {
> >  struct sunxi_mc_smp_data {
> >  	const char *enable_method;
> >  	int (*get_smp_nodes)(struct sunxi_mc_smp_nodes *nodes);
> > +	int is_a83t;  
> 
> This can be made a boolean.
> 
> Maxime
> 

ACK. It will be fixed in next version.

Best regards,

-- 
Mylène Josserand, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com