linux-kernel - Re: stable 4.16.5 hmm build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180427083006.GB25242@kroah.com>
Date:   Fri, 27 Apr 2018 10:30:06 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Михаил Носов <drdeimosnn@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jérôme Glisse <jglisse@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: stable 4.16.5 hmm build error

On Fri, Apr 27, 2018 at 10:17:42AM +0200, Arnd Bergmann wrote:
> On Fri, Apr 27, 2018 at 9:30 AM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > On Fri, Apr 27, 2018 at 02:19:24AM +0300, Михаил Носов wrote:
> >> Oh. Yes. Tag v4.16.5 without commit
> >> 9d8a463a7016e9e5578a561588a18acef139919c.
> >> It's in v4.17-rc1/2.
> >> Thank you.
> >
> > That patch does not apply to the stable trees.  I'm also confused by the
> > lack of "real" git commit ids that are being referred to here, that
> > commit refers to one that is not valid.
> >
> >> 2018-04-27 0:52 GMT+03:00 Randy Dunlap <rdunlap@...radead.org>:
> >>
> >> > https://bugzilla.kernel.org/show_bug.cgi?id=199515
> >> >
> >> > kernel/fork.o: In function `__mmdrop':
> >> > /kernel/build_kernel/linux-4.16.4/kernel/fork.c:600: undefined reference
> >> > to `hmm_mm_destroy'
> >
> > What .config is creating this?  I have not seen any kbuild reports of
> > this in the past.
> 
> I only got this through randconfig builds on mainline.
> 
> >> >
> >> > "It is also reproduced in linux-4.16.5"
> >> >
> >> >
> >> > There have been a few attempts to fix this build error.  The kernel
> >> > mainline
> >> > repo seems to have it fixed, but it looks to me like Arnd's latest patch
> >> > (9d8a463a7016e: "mm/hmm: fix header file if/else/endif maze, again")
> >> > was mis-merged to 4.16.5 stable.
> >> >
> >> > Please take a look.  Do you already have a fixup for this?
> 
> Jérôme initially created
> 
> 6b368cd4a44c ("mm/hmm: avoid bloating arch that do not make use of HMM")
> 
> which is part of v4.16. He noticed a build error that he fixed up with commit
> 
> b28b08de436a ("mm/hmm: fix header file if/else/endif maze")
> 
> which you backported as 25df8b83e867 into linux-4.16.y after v4.16.4.
> After that originally landed in mainline, I found another build error that
> I fixed with commit
> 
> 9d8a463a7016 ("mm/hmm: fix header file if/else/endif maze, again")

Why does that commit reference:
    Fixes: 8900d06a277a ("mm/hmm: fix header file if/else/endif maze")

when there is no such commit in the tree?

> This fixes the issue that Randy is reporting now, please add that into
> v4.16.5.

I tried, but it does not apply cleanly:
	$ p1 < ../mm-hmm-fix-header-file-if-else-endif-maze-again.patch
	checking file include/linux/hmm.h
	Hunk #1 FAILED at 376.
	Hunk #2 succeeded at 498 (offset -52 lines).
	1 out of 2 hunks FAILED

Am I missing some other commit that went in inbetween the above patches?

thanks,

greg k-h