linux-kernel - Re: [PATCHv3 02/11] arm64/kvm: consistently handle host HCR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180427101346.nabhblz3csp3cy36@lakrids.cambridge.arm.com>
Date:   Fri, 27 Apr 2018 11:13:46 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Christoffer Dall <christoffer.dall@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-arch@...r.kernel.org,
        drjones@...hat.com, arnd@...db.de, suzuki.poulose@....com,
        marc.zyngier@....com, catalin.marinas@....com,
        awallis@...eaurora.org, kernel-hardening@...ts.openwall.com,
        will.deacon@....com, linux-kernel@...r.kernel.org,
        ramana.radhakrishnan@....com, kvmarm@...ts.cs.columbia.edu
Subject: Re: [PATCHv3 02/11] arm64/kvm: consistently handle host HCR_EL2 flags

On Fri, Apr 27, 2018 at 11:51:39AM +0200, Christoffer Dall wrote:
> On Tue, Apr 17, 2018 at 07:37:26PM +0100, Mark Rutland wrote:
> > In KVM we define the configuration of HCR_EL2 for a VHE HOST in
> > HCR_HOST_VHE_FLAGS, but we don't ahve a similar definition for the
> 
> nit: have
> 
> > non-VHE host flags, and open-code HCR_RW. Further, in head.S we
> > open-code the flags for VHE and non-VHE configurations.
> > 
> > In future, we're going to want to configure more flags for the host, so
> > lets add a HCR_HOST_NVHE_FLAGS defintion, adn consistently use both
> 
> nit: and
> 

Sorry about those; fixed up now.

[...]

> Reviewed-by: Christoffer Dall <christoffer.dall@....com>

Cheers!

Mark.