lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Apr 2018 12:24:10 +0200 From: Philipp Zabel <p.zabel@...gutronix.de> To: Sibi Sankar <sibis@...eaurora.org>, bjorn.andersson@...aro.org, robh+dt@...nel.org Cc: linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, georgi.djakov@...aro.org, jassisinghbrar@...il.com, ohad@...ery.com, mark.rutland@....com, kyan@...eaurora.org, sricharan@...eaurora.org, akdwived@...eaurora.org, linux-arm-msm@...r.kernel.org, tsoni@...eaurora.org Subject: Re: [PATCH v4 1/5] dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs Hi Sibi, On Wed, 2018-04-25 at 20:38 +0530, Sibi Sankar wrote: > Add SDM845 AOSS (always on subsystem) reset controller binding > > Signed-off-by: Sibi Sankar <sibis@...eaurora.org> > --- > .../bindings/reset/qcom,aoss-reset.txt | 52 +++++++++++++++++++ > include/dt-bindings/reset/qcom,sdm845-aoss.h | 17 ++++++ > 2 files changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > create mode 100644 include/dt-bindings/reset/qcom,sdm845-aoss.h > > diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > new file mode 100644 > index 000000000000..e5201de9a314 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > @@ -0,0 +1,52 @@ > +Qualcomm AOSS Reset Controller > +====================================== > + > +This binding describes a reset-controller found on AOSS (always on subsystem) > +for Qualcomm SDM845 SoCs. > + > +Required properties: > +- compatible: > + Usage: required > + Value type: <string> > + Definition: must be: > + "qcom,sdm845-aoss-reset" > + > +- reg: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: must specify the base address and size of the register > + space. > + > +- #reset-cells: > + Usage: required > + Value type: <uint> > + Definition: must be 1; cell entry represents the reset index. > + > +Example: > + > +aoss_reset: qcom,reset-controller@...0100 { The node name should be "reset-controller", not "qcom,reset-controller" > + compatible = "qcom,sdm845-aoss-reset"; > + reg = <0xc2b0000 0x21000>; The address here should match the address part of the node name above. Apart from those two nitpicks, the binding looks good to me. regards Philipp
Powered by blists - more mailing lists