linux-kernel - Re: [PATCH] drm/stm: ltdc: fix warnings in ltdc_plane

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a45a726c-495e-8783-0bd8-495fbc996957@st.com>
Date:   Fri, 27 Apr 2018 13:00:04 +0000
From:   Philippe CORNU <philippe.cornu@...com>
To:     Yannick FERTRE <yannick.fertre@...com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Vincent ABRIOU <vincent.abriou@...com>,
        "David Airlie" <airlied@...ux.ie>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Alexandre TORGUE <alexandre.torgue@...com>
Subject: Re: [PATCH] drm/stm: ltdc: fix warnings in ltdc_plane_create()



On 04/25/2018 09:13 AM, Yannick FERTRE wrote:
> Hi Philippe,
> 
> Reviewed-by: Yannick Fertré <yannick.fertre@...com>
> 

Applied on drm-misc-next.
Many thanks,
Philippe :-)

> 
> On 04/19/2018 03:28 PM, Philippe Cornu wrote:
>> "make C=1" returns 2 warnings in ltdc_plane_create()
>> ("Using plain integer as NULL pointer"). This patch
>> fixes them.
>>
>> Signed-off-by: Philippe Cornu <philippe.cornu@...com>
>> ---
>>    drivers/gpu/drm/stm/ltdc.c | 4 ++--
>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 616191fe98ae..d997a6014d6c 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -860,13 +860,13 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev,
>>    
>>    	plane = devm_kzalloc(dev, sizeof(*plane), GFP_KERNEL);
>>    	if (!plane)
>> -		return 0;
>> +		return NULL;
>>    
>>    	ret = drm_universal_plane_init(ddev, plane, possible_crtcs,
>>    				       &ltdc_plane_funcs, formats, nb_fmt,
>>    				       NULL, type, NULL);
>>    	if (ret < 0)
>> -		return 0;
>> +		return NULL;
>>    
>>    	drm_plane_helper_add(plane, &ltdc_plane_helper_funcs);
>>