linux-kernel - Re: [PATCH v2] net: qrtr: Expose tunneling endpoint to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180427.105518.55533156322929879.davem@davemloft.net>
Date:   Fri, 27 Apr 2018 10:55:18 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bjorn.andersson@...aro.org
Cc:     clew@...eaurora.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2] net: qrtr: Expose tunneling endpoint to user space

From: Bjorn Andersson <bjorn.andersson@...aro.org>
Date: Mon, 23 Apr 2018 14:46:53 -0700

> +	count = min_t(size_t, iov_iter_count(to), skb->len);
> +	if (copy_to_iter(skb->data, count, to) != count)
> +		count = -EFAULT;
> +
> +	kfree_skb(skb);

As noted by Chris, you should be using consume_skb() here.

Thanks.