linux-kernel - Re: [PATCH v2 3/3] ASoC: tas6424: Allow disabling auto diagnostics for faster power-on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180427153021.GE6872@sirena.org.uk>
Date:   Fri, 27 Apr 2018 16:30:21 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jean-Jacques Hiblot <jjhiblot@...com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, perex@...ex.cz,
        tiwai@...e.com, dannenberg@...com, afd@...com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] ASoC: tas6424: Allow disabling auto diagnostics
 for faster power-on

On Fri, Apr 27, 2018 at 03:55:49PM +0200, Jean-Jacques Hiblot wrote:

> +static const char * const diags_enum_texts[] = {"OFF", "ON"};
> +static unsigned int diags_enum_values[] = {1, 0};
> +SOC_VALUE_ENUM_SINGLE_DECL(diags_enum, TAS6424_DC_DIAG_CTRL1,
> +			   TAS6424_LDGBYPASS_SHIFT, TAS6424_LDGBYPASS_MASK,
> +			   diags_enum_texts, diags_enum_values);
> +

This just just an on/off switch so it should be represented as a
standard _SINGLE() control with " Switch" at the end of the name so
userspace knows what to do with it.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)