linux-kernel - Re: [net-next] ipv6: sr: Extract the right key values for "seg6_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180428122047.ede46582a46d87139e09eea1@gmail.com>
Date:   Sat, 28 Apr 2018 12:20:47 +0200
From:   Ahmed Abdelsalam <amsalam20@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     dav.lebrun@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net-next] ipv6: sr: Extract the right key values for
 "seg6_make_flowlabel"

On Fri, 27 Apr 2018 13:59:07 -0400 (EDT)
David Miller <davem@...emloft.net> wrote:

> From: Ahmed Abdelsalam <amsalam20@...il.com>
> Date: Thu, 26 Apr 2018 16:11:11 +0200
> 
> > @@ -119,6 +119,9 @@ int seg6_do_srh_encap(struct sk_buff *skb, struct ipv6_sr_hdr *osrh, int proto)
> >  	int hdrlen, tot_len, err;
> >  	__be32 flowlabel;
> >  
> > +	inner_hdr = ipv6_hdr(skb);
> 
> You have to make this assignment after, not before, the skb_cow_header()
> call.  Otherwise this point can be pointing to freed up memory.

Ok! 
I fixed and sent you a v2 of the patch. 

-- 
Ahmed Abdelsalam <amsalam20@...il.com>