lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <b2ab24c5-92ea-5c99-af89-30c3e7ee61af@linaro.org> Date: Sat, 28 Apr 2018 14:58:27 -0500 From: Alex Elder <elder@...aro.org> To: Arvind Yadav <arvind.yadav.cs@...il.com>, hvaibhav.linux@...il.com, johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org Cc: devel@...verdev.osuosl.org, greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org Subject: Re: [greybus-dev] [PATCH v2] staging: greybus: Use gpio_is_valid() On 04/27/2018 11:35 PM, Arvind Yadav wrote: > Replace the manual validity checks for the GPIO with the > gpio_is_valid(). > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com> Looks good. Reviewed-by: Alex Elder <elder@...aro.org> > --- > chnage in v2 : > Returning invalid gpio as error instead of -ENODEV. > > drivers/staging/greybus/arche-platform.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c > index 83254a7..c3a7da5 100644 > --- a/drivers/staging/greybus/arche-platform.c > +++ b/drivers/staging/greybus/arche-platform.c > @@ -448,7 +448,7 @@ static int arche_platform_probe(struct platform_device *pdev) > arche_pdata->svc_reset_gpio = of_get_named_gpio(np, > "svc,reset-gpio", > 0); > - if (arche_pdata->svc_reset_gpio < 0) { > + if (!gpio_is_valid(arche_pdata->svc_reset_gpio)) { > dev_err(dev, "failed to get reset-gpio\n"); > return arche_pdata->svc_reset_gpio; > } > @@ -468,7 +468,7 @@ static int arche_platform_probe(struct platform_device *pdev) > arche_pdata->svc_sysboot_gpio = of_get_named_gpio(np, > "svc,sysboot-gpio", > 0); > - if (arche_pdata->svc_sysboot_gpio < 0) { > + if (!gpio_is_valid(arche_pdata->svc_sysboot_gpio)) { > dev_err(dev, "failed to get sysboot gpio\n"); > return arche_pdata->svc_sysboot_gpio; > } > @@ -487,7 +487,7 @@ static int arche_platform_probe(struct platform_device *pdev) > arche_pdata->svc_refclk_req = of_get_named_gpio(np, > "svc,refclk-req-gpio", > 0); > - if (arche_pdata->svc_refclk_req < 0) { > + if (!gpio_is_valid(arche_pdata->svc_refclk_req)) { > dev_err(dev, "failed to get svc clock-req gpio\n"); > return arche_pdata->svc_refclk_req; > } >
Powered by blists - more mailing lists