linux-kernel - [PATCH] misc: st_core: Fix skb double free corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1524895669-47953-1-git-send-email-lipengcheng8@huawei.com>
Date:   Sat, 28 Apr 2018 14:07:49 +0800
From:   Pengcheng Li <lipengcheng8@...wei.com>
To:     <linux-kernel@...r.kernel.org>
CC:     <lipengcheng8@...wei.com>, <yaobaofeng@...wei.com>,
        <lijiangxiong@...ilicon.com>, <kongfei@...ilicon.com>
Subject: [PATCH] misc: st_core: Fix skb double free corruption

When some failures happened in hci_recv_frame() function,
skb is freed by both hci_recv_frame and st_send_frame

Signed-off-by: Li Pengcheng <lipengcheng8@...wei.com>
Signed-off-by: Yao Baofeng <yaobaofeng@...wei.com>
Signed-off-by: Li Jiangxiong <lijiangxiong@...ilicon.com>
---
 drivers/misc/ti-st/st_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
index 0005159..f4ce211 100644
--- a/drivers/misc/ti-st/st_core.c
+++ b/drivers/misc/ti-st/st_core.c
@@ -124,7 +124,6 @@ static void st_send_frame(unsigned char chnl_id, struct st_data_s *st_gdata)
 			(st_gdata->list[chnl_id]->priv_data, st_gdata->rx_skb)
 			     != 0)) {
 			pr_err(" proto stack %d's ->recv failed", chnl_id);
-			kfree_skb(st_gdata->rx_skb);
 			return;
 		}
 	} else {
-- 
2.8.0