[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3485fade-56fd-0078-a330-41187445c984@synopsys.com>
Date: Mon, 30 Apr 2018 17:30:20 +0100
From: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
To: Alan Douglas <adouglas@...ence.com>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
"Joao.Pinto@...opsys.com" <Joao.Pinto@...opsys.com>,
"jingoohan1@...il.com" <jingoohan1@...il.com>,
"kishon@...com" <kishon@...com>,
"jesper.nilsson@...s.com" <jesper.nilsson@...s.com>
Cc: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/10] misc: pci_endpoint_test: Add MSI-X support
Hi Alan,
On 30/04/2018 16:35, Alan Douglas wrote:
> Hi Gustavo,
>
> On April 27, 2018, 4:57 p.m. Gustavo Pimentel wrote:
>> Add MSI-X support and update driver documentation accordingly.
>>
>> Add new driver parameter to allow interruption type selection.
>>
>> Modify the Legacy/MSI/MSI-X test process, by:
>> - Add and use a specific register located in a BAR, which defines the interrupt
>> type is been triggered.
>> - Move the interrupt ID number from the command section to a register
>> located in a BAR.
>>
>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
>> ---
>> Documentation/misc-devices/pci-endpoint-test.txt | 3 +
>> drivers/misc/pci_endpoint_test.c | 121 +++++++++++++++--------
>> drivers/pci/endpoint/functions/pci-epf-test.c | 78 +++++++++++----
>> 3 files changed, 143 insertions(+), 59 deletions(-)
>>
> In testing these changes I found that pci_epc_raise_irq() also needs to be
> updated in pci-epc-core.c, since it has interrupt_num parameter as u8
Yes, indeed. I updated it together with the pci-epc.h file.
Thanks Alan, well spotted!
Regards,
Gustavo
>
> Thanks,
> Alan
>
Powered by blists - more mailing lists